feat: Swarm.RelayService.InfiniteLimits #9662
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
commented
Feb 22, 2023
| @@ -67,7 +67,7 @@ require ( | |||
| github.com/jbenet/go-temp-err-catcher v0.1.0 | |||
| github.com/jbenet/goprocess v0.1.4 | |||
| github.com/libp2p/go-doh-resolver v0.4.0 | |||
| github.com/libp2p/go-libp2p v0.25.1 | |||
| github.com/libp2p/go-libp2p v0.25.2-0.20230222220431-c03190e1ca4f | |||
There was a problem hiding this comment.
ℹ️ switch to release after #9656 lands.
lidel
commented
Feb 22, 2023
Comment on lines
+97
to
+99
| // InfiniteLimits effectively removes all limits. Enabling this option also | ||
| // doesn't apply any filter for which protocols can be used, allowing for | ||
| // expensive things like bitswap over a relayed connection. |
There was a problem hiding this comment.
💭 need to confirm bitswap works over a static v2 relay when we run with infinite limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs #9656 to land first.
Context
Allowing users to switch from additional v1 relays to built-in v2 in Kubo.
The idea here is to expose libp2p/go-libp2p#2125 as an experimental, opt-in configuration option,
for running an unlimited relay in controlled environments (when relay and clients are managed by the same entity).
We want to fix/update tutorial from ipfs/ipfs-docs#1459. If we can remove the need for asking people to run a separate libp2p-relay-daemon v1), and only run Kubo, that it is a big win and reduction in complexity and DX/UX win.
TODO
cc @2color @TheDiscordian for visibility